-
-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix javascript lint errors #6214 #6221
Open
bhavishy2801
wants to merge
30
commits into
stdlib-js:develop
Choose a base branch
from
bhavishy2801:Fix-JavaScript-lint-errors-#6214
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
4f28c68
chore: fix JavaScript lint errors #6214
bhavishy2801 2340149
chore: fix JavaScript lint errors #6214
bhavishy2801 701c8b6
Update polyfill.js
bhavishy2801 7e15762
Update polyfill.js
bhavishy2801 b2d2c7c
Updated polyfill.js
bhavishy2801 b163856
Updated polyfill.js
bhavishy2801 e7dccbd
Updated polyfill.js
bhavishy2801 ed0570c
Updated polyfill.js
bhavishy2801 df9cd46
Updated polyfill.js
bhavishy2801 cc54540
Updated polyfill.js
bhavishy2801 175b6c8
Updated polyfill.js
bhavishy2801 43e1bbc
Updated polyfill.js
bhavishy2801 4d5dfa3
Updated main.js
bhavishy2801 09f7346
Updated polyfill.js
bhavishy2801 6980d23
Updated polyfill.js
bhavishy2801 5b12782
Updated polyfill.js
bhavishy2801 3b71ac6
Updated polyfill.js
bhavishy2801 f1e2e47
Updated polyfill.js
bhavishy2801 135d208
Updated polyfill.js
bhavishy2801 d6d8015
Updated polyfill.js
bhavishy2801 5f189c0
Updated polyfill.js
bhavishy2801 51620f6
Updated polyfill.js
bhavishy2801 a092b94
Updated polyfill.js
bhavishy2801 7e5a0f6
Updated polyfill.js
bhavishy2801 b43e355
Updated polyfill.js
bhavishy2801 a7c39ab
Updated polyfill.js
bhavishy2801 da25f36
Updated polyfill.js
bhavishy2801 978501e
Updated polyfill.js
bhavishy2801 b8c4077
Updated polyfill.js
bhavishy2801 a90e1e3
Updated polyfill.js
bhavishy2801 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,7 +25,6 @@ | |
* | ||
* @private | ||
* @param {Object} target - target object to wrap | ||
* @param {Object} handlers - object whose properties are functions defining proxy behavior | ||
* @returns {Object} proxied object | ||
* | ||
* @example | ||
|
@@ -42,9 +41,11 @@ | |
* p.a = 3.14; | ||
* | ||
* var x = p.a; | ||
* // eslint-disable-next-line stdlib/jsdoc-doctest-marker | ||
* // returns 6.28 | ||
*/ | ||
function Proxy( target ) { | ||
// eslint-disable-next-line no-warning-comments | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Still incorrect. |
||
// TODO: polyfill implementation | ||
return target; | ||
} | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposed changes are not the desired changes, in this case. Instead, because we still need the polyfill implementation, at L47, you should just disable doctesting using a
eslint-disable-line
comment. This rule can be re-enabled once the polyfill is completed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have also yet to revert the changes to this file.