Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix C lint errors (issue #6238) #6254

Closed
wants to merge 6 commits into from
Closed

chore: fix C lint errors (issue #6238) #6254

wants to merge 6 commits into from

Conversation

nishant1194
Copy link

Resolves #6238 .

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Mar 21, 2025
@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Mar 31, 2025
kgryte
kgryte reviewed Mar 31, 2025
View reviewed changes
lib/node_modules/@stdlib/math/base/special/floor10/src/addon.c
@@ -19,4 +19,4 @@
#include "stdlib/math/base/special/floor10.h"
#include "stdlib/math/base/napi/unary.h"

STDLIB_MATH_BASE_NAPI_MODULE_D_D( stdlib_base_floor10 )
STDLIB_MATH_BASE_NAPI_MODULE_D_D( floor10_func )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the desired change. See other addon.c files in other packages for what is desired.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 31, 2025
@kgryte
Copy link
Member

kgryte commented Apr 1, 2025

Ref: #6481

@kgryte kgryte added the autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. label Apr 1, 2025
@stdlib-bot
Copy link
Contributor

Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit.

Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions.

@stdlib-bot stdlib-bot closed this Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte left review comments

Assignees
No one assigned
Labels
autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Math Issue or pull request specific to math functionality. Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix C lint errors
3 participants
@nishant1194 @kgryte @stdlib-bot