adding `bernoullif` #6260

Girish-Garg · 2025-03-21T11:19:21Z

Resolves #649 .

Description

What is the purpose of this pull request?

This pull request:

adding bernoullif

Related Issues

Does this pull request have any related issues?

This pull request:

resolves [RFC]: Add C implementations to base special math functions (tracking issue) #649

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

Girish-Garg · 2025-03-21T11:19:46Z

@anandkaranubc this is the PR

stdlib-bot · 2025-03-21T11:19:59Z

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

Please read our contributing guidelines.
Update your pull request description to include this checked box:

- [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

The developer's certificate of origin
Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

anandkaranubc · 2025-03-21T11:47:51Z

lib/node_modules/@stdlib/math/base/special/bernoullif/lib/main.js

+
+// VARIABLES //
+
+var MAX_BERNOULLI = 64|0; // asm type annotation


How did you choose 64 here?

It seems correct though:

In [15]: base.abs(base.bernoulli(66)) < FLOAT32_MAX Out[15]: false In [16]: base.abs(base.bernoulli(64)) < FLOAT32_MAX Out[16]: true

i convert all existing values to float32 till it become infinite

which mean it exceed float limits
you can see this as well in c file that last value is almost touching float limit

this value worked for JS perfectly as i have checked its test cases and logged all the value outcomes as well (to crosscheck)

anandkaranubc · 2025-03-21T11:52:50Z

lib/node_modules/@stdlib/math/base/special/bernoullif/src/main.c

+*/
+float stdlib_base_bernoullif( const int32_t n ) {
+	if ( n < 0 ) {
+		return nanf(""); // NaN


Suggested change

return nanf(""); // NaN

return 0.0f / 0.0f; // NaN

FYI, after this change, I was able to build the native addon locally.

NODE_ADDONS_PATTERN="@stdlib/math/base/special/bernoullif" make install-node-addons

yaa actually while running node-gyp it gave error which is :

C:\Users\gargg\Coding\stdlib\lib\node_modules\@stdlib\math\base\special\bernoullif\src\main.c(75,14): error C2124: divide or mod by zero [C:\Users\gargg\Coding\stdlib\lib\node_m odules\@stdlib\math\base\special\bernoullif\build\addon.vcxproj]

so i changed it temporarily to duplicate NaN for checking tests and all
i have checked by changing it back to 0.0f/0.0f and ran command for addon given by you its still showing the error given above

My best guess is that it is your C++ compiler which is detecting that 0.0f / 0.0f is an explicit division by zero and is throwing a compilation error.

nah still not working

Can you push all the changes you made to this PR so I can confirm if they are correct?

ohk wait a bit

@anandkaranubc done

@Girish-Garg It's working perfectly fine on my end. It seems to be a C compiler error on your side.

anandkaranubc · 2025-03-21T11:59:34Z

@Girish-Garg This PR progresses #649 rather than "resolves" it.

Girish-Garg · 2025-03-21T12:23:49Z

@Girish-Garg This PR progresses #649 rather than "resolves" it.

yaa i will change the title and all its just reference pr for errors to be checked

Signed-off-by: Girish Garg <[email protected]>

lib/node_modules/@stdlib/math/base/special/bernoullif/src/main.c

Co-authored-by: Neeraj Pathak <[email protected]> Signed-off-by: Girish Garg <[email protected]>

Girish-Garg · 2025-03-22T09:11:46Z

@Neerajpathak07 error from my side still not resolved

Girish-Garg · 2025-03-22T13:05:16Z

@anandkaranubc should i set the PR for review as the code is working for you means its working...and if not can you run all the test/examples/benchmark for me as i am unable to

anandkaranubc · 2025-03-22T17:39:52Z

@anandkaranubc should i set the PR for review as the code is working for you means its working...

When I said it's working, I meant that I was able to build the native addon. Your tests are still failing, and the PR is not ready for review. Look for different sources to fix your compiler error; you can't always rely on CI/CD workflows to point out exactly where the issue is.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: passed - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

This commit removes the `ops` symbol from the `@stdlib/math/base` namespace due to a package migration. BREAKING CHANGE: remove `ops` --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

Ref: stdlib-js#2261 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

This commit removes `@stdlib/math/base/ops`. BREAKING CHANGE: remove `math/base/ops` Ref: stdlib-js#2261 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

PR-URL: stdlib-js#6304 Ref: stdlib-js#649 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Athan Reines <[email protected]>

PR-URL: stdlib-js#6295 Closes: stdlib-js#5664 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Athan Reines <[email protected]>

PR-URL: stdlib-js#6266 Closes: stdlib-js#5652 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Athan Reines <[email protected]>

PR-URL: stdlib-js#6277 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Athan Reines <[email protected]>

PR-URL: stdlib-js#6044 Closes: stdlib-js#4977 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: hemantmm <[email protected]> Signed-off-by: Athan Reines <[email protected]>

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

PR-URL: stdlib-js#6278 Closes: stdlib-js#6270 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Athan Reines <[email protected]>

PR-URL: stdlib-js#6279 Closes: stdlib-js#6272 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Athan Reines <[email protected]>

PR-URL: stdlib-js#6317 Reviewed-by: Athan Reines <[email protected]>

PR-URL: stdlib-js#6316 Reviewed-by: Athan Reines <[email protected]>

PR-URL: stdlib-js#6314 Reviewed-by: Athan Reines <[email protected]>

PR-URL: stdlib-js#6315 Reviewed-by: Athan Reines <[email protected]>

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

PR-URL: stdlib-js#6323 Reviewed-by: Athan Reines <[email protected]>

PR-URL: stdlib-js#6325 Reviewed-by: Athan Reines <[email protected]>

PR-URL: stdlib-js#6324 Closes: stdlib-js#6312 Reviewed-by: Athan Reines <[email protected]>

stdlib-bot · 2025-03-23T11:05:01Z

Coverage Report

Package	Statements	Branches	Functions	Lines
math/base/special/bernoullif	$\color{green}239/239$ $\color{green}+100.00\%$	$\color{green}16/16$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}239/239$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

… into feat/bernoullif

Girish-Garg · 2025-03-23T11:22:05Z

@anandkaranubc i did all the required changes but when committed these other commits automatically happened??

adding bernoullif

d97c96a

stdlib-bot added Math Issue or pull request specific to math functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. labels Mar 21, 2025

anandkaranubc reviewed Mar 21, 2025

View reviewed changes

Girish-Garg added 2 commits March 22, 2025 10:14

Update main.c

3d264b5

Signed-off-by: Girish Garg <[email protected]>

Update manifest.json

2ec1aee

Signed-off-by: Girish Garg <[email protected]>

Girish-Garg mentioned this pull request Mar 22, 2025

[RFC]: developer dashboard for tracking ecosystem build failures stdlib-js/google-summer-of-code#110

Open

7 tasks

Neerajpathak07 reviewed Mar 22, 2025

View reviewed changes

lib/node_modules/@stdlib/math/base/special/bernoullif/src/main.c Outdated Show resolved Hide resolved

Update lib/node_modules/@stdlib/math/base/special/bernoullif/src/main.c

a07a770

Co-authored-by: Neeraj Pathak <[email protected]> Signed-off-by: Girish Garg <[email protected]>

kgryte added 13 commits March 23, 2025 16:23

gururaj1512 and others added 24 commits March 23, 2025 16:23

feat: add constants/float32/apery

7b505d9

PR-URL: stdlib-js#6304 Ref: stdlib-js#649 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Athan Reines <[email protected]>

feat: add accessor protocol and refactor stats/base/nanmskrange

da10e0b

PR-URL: stdlib-js#6295 Closes: stdlib-js#5664 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Athan Reines <[email protected]>

feat: refactor and add protocol support to stats/base/meanwd

62c26dd

PR-URL: stdlib-js#6266 Closes: stdlib-js#5652 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Athan Reines <[email protected]>

docs: add examples for string and float formatting

61e23b0

PR-URL: stdlib-js#6277 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Athan Reines <[email protected]>

chore: fix EditorConfig lint errors

18bf1b9

PR-URL: stdlib-js#6278 Closes: stdlib-js#6270 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Athan Reines <[email protected]>

chore: fix C lint errors

ddd6b55

PR-URL: stdlib-js#6279 Closes: stdlib-js#6272 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Athan Reines <[email protected]>

docs: update namespace table of contents

03097f2

PR-URL: stdlib-js#6317 Reviewed-by: Athan Reines <[email protected]>

docs: update REPL namespace documentation

b696310

PR-URL: stdlib-js#6316 Reviewed-by: Athan Reines <[email protected]>

docs: update list of contributors

0374b18

PR-URL: stdlib-js#6314 Reviewed-by: Athan Reines <[email protected]>

feat: update namespace TypeScript declarations

d42757f

PR-URL: stdlib-js#6315 Reviewed-by: Athan Reines <[email protected]>

docs: use correct function name

d8a0922

PR-URL: stdlib-js#6323 Reviewed-by: Athan Reines <[email protected]>

docs: add examples for string and float formatting

d2cab68

PR-URL: stdlib-js#6325 Reviewed-by: Athan Reines <[email protected]>

chore: fix JavaScript lint errors

f7c0673

PR-URL: stdlib-js#6324 Closes: stdlib-js#6312 Reviewed-by: Athan Reines <[email protected]>

updated tests

b0e8a31

Merge branch 'stdlib-js:develop' into feat/bernoullif

2917d57

Girish-Garg added 2 commits March 23, 2025 16:45

updated docs

4d55398

Merge branch 'feat/bernoullif' of https://github.com/Girish-Garg/stdlib…

e1efb4d

… into feat/bernoullif

Girish-Garg closed this Mar 24, 2025

Girish-Garg deleted the feat/bernoullif branch March 24, 2025 14:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding `bernoullif` #6260

adding `bernoullif` #6260

Girish-Garg commented Mar 21, 2025 •

edited

Loading

Girish-Garg commented Mar 21, 2025

stdlib-bot commented Mar 21, 2025

anandkaranubc Mar 21, 2025

anandkaranubc Mar 21, 2025

Girish-Garg Mar 21, 2025

Girish-Garg Mar 21, 2025

Girish-Garg Mar 21, 2025 •

edited

Loading

anandkaranubc Mar 21, 2025

anandkaranubc Mar 21, 2025

Girish-Garg Mar 21, 2025 •

edited

Loading

Girish-Garg Mar 21, 2025

anandkaranubc Mar 21, 2025

Girish-Garg Mar 22, 2025

anandkaranubc Mar 22, 2025

Girish-Garg Mar 22, 2025

Girish-Garg Mar 22, 2025

anandkaranubc Mar 22, 2025

anandkaranubc commented Mar 21, 2025 •

edited

Loading

Girish-Garg commented Mar 21, 2025 •

edited

Loading

Girish-Garg commented Mar 22, 2025

Girish-Garg commented Mar 22, 2025

anandkaranubc commented Mar 22, 2025

stdlib-bot commented Mar 23, 2025 •

edited

Loading

Girish-Garg commented Mar 23, 2025


		// VARIABLES //

		var MAX_BERNOULLI = 64\|0; // asm type annotation

adding bernoullif #6260

adding bernoullif #6260

Conversation

Girish-Garg commented Mar 21, 2025 • edited Loading

Description

Related Issues

Questions

Other

Checklist

Girish-Garg commented Mar 21, 2025

stdlib-bot commented Mar 21, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Girish-Garg Mar 21, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Girish-Garg Mar 21, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anandkaranubc commented Mar 21, 2025 • edited Loading

Girish-Garg commented Mar 21, 2025 • edited Loading

Girish-Garg commented Mar 22, 2025

Girish-Garg commented Mar 22, 2025

anandkaranubc commented Mar 22, 2025

stdlib-bot commented Mar 23, 2025 • edited Loading

Coverage Report

Girish-Garg commented Mar 23, 2025

adding `bernoullif` #6260

adding `bernoullif` #6260

Girish-Garg commented Mar 21, 2025 •

edited

Loading

Girish-Garg Mar 21, 2025 •

edited

Loading

Girish-Garg Mar 21, 2025 •

edited

Loading

anandkaranubc commented Mar 21, 2025 •

edited

Loading

Girish-Garg commented Mar 21, 2025 •

edited

Loading

stdlib-bot commented Mar 23, 2025 •

edited

Loading