Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix EditorConfig lint errors (issue #6270) #6278

Merged
merged 4 commits into from
Mar 22, 2025
Merged

chore: fix EditorConfig lint errors (issue #6270) #6278

merged 4 commits into from
Mar 22, 2025

Conversation

AaryaBalwadkar
Copy link
Contributor

Resolves #6270.

Description

What is the purpose of this pull request?

This pull request:

  • Fixes extra spaces issues in lib/node_modules/@stdlib/lapack/base/dge-trans/test/test.ndarray.js files by removing extra spaces to comply with EditorConfig rules.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Mar 22, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 22, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
lapack/base/dge-trans $\color{green}348/348$
$\color{green}+100.00\%$ 		$\color{green}19/19$
$\color{green}+100.00\%$ 		$\color{green}3/3$
$\color{green}+100.00\%$ 		$\color{green}348/348$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte
style: preserve value alignment
c8d43b4 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte previously approved these changes Mar 22, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Mar 22, 2025
@kgryte
style: enable lint rule
40493fd 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte previously approved these changes Mar 22, 2025
View reviewed changes
@kgryte
style: update lint directive
27003f4 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte merged commit b1e106f into stdlib-js:develop Mar 22, 2025
10 checks passed
@AaryaBalwadkar AaryaBalwadkar deleted the fix/editorconfig-indentation-6270 branch March 23, 2025 04:19
Girish-Garg pushed a commit to Girish-Garg/stdlib that referenced this pull request Mar 23, 2025
@AaryaBalwadkar @kgryte @Girish-Garg
chore: fix EditorConfig lint errors
18bf1b9 
PR-URL: stdlib-js#6278
Closes: stdlib-js#6270
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Signed-off-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix EditorConfig lint errors
3 participants
@AaryaBalwadkar @stdlib-bot @kgryte