Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add constants/float32/num-significand-bits #6284

Merged
merged 6 commits into from
Mar 24, 2025
Merged

feat: add constants/float32/num-significand-bits #6284

merged 6 commits into from
Mar 24, 2025

Conversation

hrshya
Copy link
Contributor

@hrshya hrshya commented Mar 22, 2025 •
edited
Loading

Progresses #649 .

Description

What is the purpose of this pull request?

This pull request:

  • adds constants/float32/num-significand-bits .

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 22, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 22, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
constants/float32/num-significand-bits $\color{green}47/47$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}0/0$
$\color{green}+100.00\%$ 		$\color{green}47/47$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Mar 22, 2025
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 22, 2025
@hrshya hrshya requested a review from kgryte March 23, 2025 12:48
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 23, 2025
@hrshya hrshya changed the title feat: add constants/float32/significand-bits feat: add constants/float32/num-significand-bits Mar 23, 2025
@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Mar 24, 2025
kgryte
kgryte approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Mar 24, 2025
@kgryte kgryte merged commit 56b84a4 into stdlib-js:develop Mar 24, 2025
35 checks passed
sahil20021008 pushed a commit to sahil20021008/stdlib that referenced this pull request Mar 26, 2025
@hrshya @sahil20021008
feat: add constants/float32/num-significand-bits
19022b1 
PR-URL: stdlib-js#6284
Ref: stdlib-js#649
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: Harsh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hrshya @stdlib-bot @kgryte