fix: handle missing properties, error types, and stack in @stdlib/error/reviver #6353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: handle missing properties, error types, and stack in @stdlib/error/reviver
This PR fixes three functional bugs in the
@stdlib/error/reviver
module that affect the correctness and reliability of thereviver
function.Bug Fixes
lib/index.js
reviver
function did not handle missingmessage
,name
, orstack
properties, leading to incorrectError
objects (e.g., a message of"undefined"
ifvalue.message
was undefined).message
andname
, and only setstack
if it’s a string.Error
constructor, ignoring the specific error type (e.g.,SyntaxError
,TypeError
), causing the revived error to have the wrong type.value.name
.stack
property is not writable orvalue.stack
is not a string, which could cause issues in some environments.stack
is only set ifvalue.stack
is a string and thestack
property is writable.test/test.js
TypeError
) to ensure the fixes are robust.Checklist