-
-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add constants/float32/max-safe-lucas
#6374
base: develop
Are you sure you want to change the base?
Conversation
constants/float32/max-safe-lucas
Coverage Report
The above coverage report was generated for the changes in this PR. |
* | ||
* @constant | ||
* @type {integer} | ||
* @default 1197222447 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hrshya How did you come up with this number, 1197222447
?
Actually, it must be:
In [5]: FLOAT32_MAX_SAFE_INTEGER > 12752043
Out[5]: true
In [6]: FLOAT32_MAX_SAFE_INTEGER > 20633239
Out[6]: false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1197222447
isn't a Lucas number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, after double checking the correct value is indeed 12752043. Thanks for pointing that out
Progresses #649 .
Description
This pull request:
constants/float32/max-safe-lucas
.Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers