Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stats): add nanminmaxabs - incremental min/max absolute values ignoring NaNs #6387

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

AlyAbdelmoneim
Copy link
Contributor

Resolves #5580.

Description

What is the purpose of this pull request?

This pull request:

  • Adds nanminmaxabs, an incremental accumulator for computing the minimum and maximum absolute values while ignoring NaN values.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 26, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/incr/nanminmaxabs $\color{green}137/137$
$\color{green}+100.00\%$
$\color{red}14/15$
$\color{green}+93.33\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}137/137$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@AlyAbdelmoneim
Copy link
Contributor Author

I'm stuck on linting errors and have been trying to fix them for too long. If anyone wants to take over this issue, you're more than welcome! Any help in figuring out the problem would also be greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: add stats/incr/nanminmaxabs
2 participants