Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update main.js #6426

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Update main.js #6426

wants to merge 1 commit into from
+1 −0

Conversation

VeerRaj-007
Copy link

@VeerRaj-007 VeerRaj-007 commented Mar 28, 2025 •
edited
Loading

Issue: A TODO comment triggers the no-warning-comments ESLint rule.

Fix: Suppress the warning for this specific line by adding an ESLint disable comment.

Resolves #{{TODO: add issue number}}.

Description

What is the purpose of this pull request?

This pull request:

  • {{TODO: add description describing what this pull request does}}

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves #{{TODO: add issue number}}

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@VeerRaj-007
Update main.js
e1d0ffb 
Issue: A TODO comment triggers the no-warning-comments ESLint rule.

Fix: Suppress the warning for this specific line by adding an ESLint disable comment.

Signed-off-by: VEER RAJ <[email protected]>
@stdlib-bot stdlib-bot added Tools Issue or pull request related to project tooling. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. labels Mar 28, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

stdlib-bot
stdlib-bot reviewed Mar 28, 2025
View reviewed changes
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@VeerRaj-007 VeerRaj-007 marked this pull request as ready for review March 30, 2025 10:36
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 30, 2025
kgryte
kgryte reviewed Mar 31, 2025
View reviewed changes
lib/node_modules/@stdlib/_tools/bundle/pkg-list/lib/main.js
@@ -195,6 +195,7 @@ function bundle( pkgs, options, clbk ) {
debug( 'Browserify options: %s', JSON.stringify( bopts ) );
return browserifyString( out, bopts, onBundle );
}
// eslint-disable-next-line no-warning-comments
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not desired.

@kgryte
Copy link
Member

kgryte commented Mar 31, 2025

What is the issue number you are attempting to resolve?

@kgryte kgryte added Invalid Invalid question, issue, or pull request. and removed Needs Review A pull request which needs code review. labels Mar 31, 2025
@VeerRaj-007
Copy link
Author

What is the issue number you are attempting to resolve?

#6417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte left review comments

@stdlib-bot stdlib-bot stdlib-bot left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Invalid Invalid question, issue, or pull request. Tools Issue or pull request related to project tooling.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VeerRaj-007 @stdlib-bot @kgryte