Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix JavaScript lint errors #6453

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix JavaScript lint errors #6453

wants to merge 1 commit into from

Conversation

VeerRaj-007
Copy link

@VeerRaj-007 VeerRaj-007 commented Mar 30, 2025 •
edited
Loading

Issue: Using new Array() violates the stdlib/no-new-array rule.

fix: creating an array using an array literal

Resolves #6417

Description

What is the purpose of this pull request?

This pull request:

  • creating an array using an array literal instead of a new Array ()

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@VeerRaj-007
fix JavaScript lint errors
2d93932 
Issue: Using new Array() violates the stdlib/no-new-array rule.

fix: creating array using an array literal 

Signed-off-by: VEER RAJ <136178369+VeerRaj-007@users.noreply.github.com>
@stdlib-bot stdlib-bot added the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Mar 30, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
utils/async/if-then $\color{green}201/201$
$\color{green}+100.00\%$ 		$\color{green}21/21$
$\color{green}+100.00\%$ 		$\color{green}3/3$
$\color{green}+100.00\%$ 		$\color{green}201/201$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Mar 30, 2025
@VeerRaj-007 VeerRaj-007 marked this pull request as ready for review March 30, 2025 11:06
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 30, 2025
kgryte
kgryte reviewed Mar 31, 2025
View reviewed changes
lib/node_modules/@stdlib/utils/async/if-then/lib/main.js
@@ -119,7 +119,7 @@ function ifthenAsync( predicate, x, y, done ) {
return done( error );
}
nargs = arguments.length;
args = new Array( nargs );
args = Array.from({ length: nargs });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not what we want. This project uses ES5. The lint error message tells you explicitly what you should be doing to resolve this issue.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors
3 participants
@VeerRaj-007 @stdlib-bot @kgryte