Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bench: replace base/uniform with array/uniform #6454

Merged
merged 1 commit into from
Mar 30, 2025
Merged

bench: replace base/uniform with array/uniform #6454

merged 1 commit into from
Mar 30, 2025

Conversation

sahil20021008
Copy link
Contributor

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: na
  • task: lint_package_json status: na
  • task: lint_repl_help status: na
  • task: lint_javascript_src status: na
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: na
  • task: lint_javascript_tests status: na
  • task: lint_javascript_benchmarks status: passed
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: na
  • task: lint_typescript_tests status: na
  • task: lint_license_headers status: passed ---

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

  • Fixes the invalid array indexing in the JS benchmarks of math/base/special/gamma-lanczos-sum. By changing the uniform library from being imported from base to array, uniform function returns an array which we can iterate over.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@sahil20021008
bench: fix invalid array indexing
8134371 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Mar 30, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/gamma-lanczos-sum $\color{red}255/258$
$\color{green}+98.84\%$ 		$\color{red}8/10$
$\color{green}+80.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{red}255/258$
$\color{green}+98.84\%$

The above coverage report was generated for the changes in this PR.

@sahil20021008
Copy link
Contributor Author

@anandkaranubc , have raised the PR for gamma-lanczos-sum benchmark fix
cc: @hrshya
Reference PR: #6331

@sahil20021008 sahil20021008 mentioned this pull request Mar 25, 2025
Open
7 tasks
@anandkaranubc anandkaranubc changed the title bench: fix invalid array indexing bench: replace base/uniform with array/uniform Mar 30, 2025
anandkaranubc
anandkaranubc approved these changes Mar 30, 2025
View reviewed changes
Copy link
Contributor

@anandkaranubc anandkaranubc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for fixing that 😃

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Mar 30, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 30, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

bench: replace `base/uniform` with `array/uniform`

PR-URL: https://github.com/stdlib-js/stdlib/pull/6454

Co-authored-by: Sahil Goyal <[email protected]>
Reviewed-by: anandkaranubc <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 6a954bc into stdlib-js:develop Mar 30, 2025
87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandkaranubc anandkaranubc anandkaranubc approved these changes

Assignees
No one assigned
Labels
First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sahil20021008 @stdlib-bot @anandkaranubc @Planeshifter