Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rough first pass at the option to obfuscate values #9

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

brendanlensink
Copy link
Collaborator

For #6

Adds:

  • the --obfuscate tag, which allows you to toggle value obfuscation.
  • cleans up the logging logic a little, moving the check for debug to a singleton rather than having to pass our debug setting around into our helper models.

Questions:

  • Do we maybe want to flip the logic here and just obfuscate by default?
  • @nbrooke I tried to google around a little to understand how Swift apps get compiled and what the executable ends up looking like, but wasn't able to get a really satisfying answer, but I'm really curious how secure this actually is?

Like we're providing the salt right in the same file, so theoretically all the information you need to decrypt the values are right there. I know security by obfuscation isn't supposed to be rock solid, but am mostly just curious how much of a different this makes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants