Update Bluejay.swift #227
Open
Update Bluejay.swift #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed bug in start with mode .use (added missing restoration centralManager delegate) and then added queue.start()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119
Fixed bug in start with mode .use (added missing restoration centralManager delegate) and then added queue.start()
Summary of Problem:
There is a missing delegation restoration when using start with mode .use
(we were forced to use start with mode .use because in iOS 13 bluejay.start() and connect() no longer work after another cbCentralManager has completed a scan (prior to iOS13, another scan with another cbCentralManager was not required )
For further info about this issue, feel free to contact me.
Proposed Solution:
When recycling a cbCentralManager we need to restore its delegation to bluejay.
Also it is necessary to add queue.start() to solve the issue in #119 "Queue is paused because CBCentralManager is not ready yet" as @jeremychiang proposed.
Testing Completed and Required:
Screenshots: