Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't overflow text in linter-tooltip #471

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

szhu
Copy link
Contributor

@szhu szhu commented Feb 1, 2018

Text is currently allowed to overflow out of the linter tooltip. This has always been case, but with #467 and a custom stylesheet of mine that makes the unexpanded part one line (with white-space: nowrap), overflowing can actually happen.

image

This PR hides the overflow.

@steelbrain
Copy link
Owner

steelbrain commented Feb 2, 2018

I think we should wrap the overflowed part instead of hiding it. Thoughts?

Edit I'm having a hard-time having it over-flowed it just wraps in the cases I tested. Can you please provide a test case where it overflows like that?

@szhu
Copy link
Contributor Author

szhu commented Feb 7, 2018

There is no public test case, I have a custom stylesheet that causes some pieces of text to not wrap.

What this PR does is, given than some pieces of text are explicitly set to not wrap (either in other people's stylesheets or in the stylesheet of some future linter plugin), to hide the overflow rather than showing the text outside the tooltip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants