V2.0.3 Architecture Change #115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First of all, amazing work done over the years. I remember when I first played I thought on the idea of automating but never got to it. Have tried this and has been really good. In order to contribute to this and pay it forward I have spent some time rearchitecting this to work as an actual package. No features have been changed only the way some parts work. There are more things that require cleaning up and fine-tuning, so I will spend some time on that as well. Things I have changed. - Added workflows to manage pull requests as well as publishing to PyPi - Added some test coverage as well as typing standard (currently test coverage and typing fail due to not being standardised but this can be worked on to get it to succeed over time) - Rearranged the file layout to work as a library - Considering it has been changed to be a library I have changed the way templates and cache get created in a project in order to have it created in the local user folder at startup - Cleaned up some code as well in the main bot class This pull request require further changes to main repo: - Changes to release pipeline - Adjust pypi for new contributors - Change Repo name - change branch name to main Some further work I will be doing - Improve config setup on first startup - Stabilise code
matthewmoorcroft
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, amazing work done over the years. I remember when I first played I thought on the idea of automating but never got to it. Have tried this and has been really good. In order to contribute to this and pay it forward I have spent some time rearchitecting this to work as an actual package. No features have been changed only the way some parts work. There are more things that require cleaning up and fine-tuning, so I will spend some time on that as well. Things I have changed.
pip install TWBotThis pull request require further changes to main repo:
Some further work I will be doing