Use DIRECTORRY_SEPERATOR to support Windows (#38)

* Use DIRECTORY_SEPARATOR instead of /
stefanzweifel · Oct 27, 2023 · 997f15f · 997f15f
1 parent 4a4954e
commit 997f15f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/Databases/MySql.php b/src/Databases/MySql.php
@@ -13,7 +13,7 @@ class MySql extends DbImporter
 
     public function getImportCommand(string $dumpFile, string $connection): string
     {
-        $temporaryDirectoryPath = config('backup.backup.temporary_directory') ?? storage_path('app/backup-temp');
+        $temporaryDirectoryPath = config('backup.backup.temporary_directory') ?? storage_path('app'.DIRECTORY_SEPARATOR.'backup-temp');
 
         $this->temporaryDirectory = (new TemporaryDirectory($temporaryDirectoryPath))
             ->name('temp')

diff --git a/src/PendingRestore.php b/src/PendingRestore.php
@@ -43,33 +43,33 @@ public function getPathToLocalCompressedBackup(): string
     {
         $filename = "$this->restoreId.{$this->getFileExtensionOfRemoteBackup()}";
 
-        return "backup-restore-temp/$filename";
+        return 'backup-restore-temp'.DIRECTORY_SEPARATOR.$filename;
     }
 
     public function getPathToLocalDecompressedBackup(): string
     {
         $filename = $this->restoreId;
 
-        return "backup-restore-temp/$filename";
+        return 'backup-restore-temp'.DIRECTORY_SEPARATOR.$filename;
     }
 
     public function getAbsolutePathToLocalDecompressedBackup(): string
     {
         $filename = $this->restoreId;
 
-        return storage_path("app/backup-restore-temp/$filename");
+        return storage_path('app'.DIRECTORY_SEPARATOR.'backup-restore-temp'.DIRECTORY_SEPARATOR.$filename);
     }
 
     public function hasNoDbDumpsDirectory(): bool
     {
         return ! Storage::disk($this->restoreDisk)
-            ->has("{$this->getPathToLocalDecompressedBackup()}/db-dumps");
+            ->has($this->getPathToLocalDecompressedBackup().DIRECTORY_SEPARATOR.'db-dumps');
     }
 
     public function getAvailableDbDumps(): Collection
     {
         $files = Storage::disk($this->restoreDisk)
-            ->files("{$this->getPathToLocalDecompressedBackup()}/db-dumps");
+            ->files($this->getPathToLocalDecompressedBackup().DIRECTORY_SEPARATOR.'db-dumps');
 
         return collect($files)
             ->filter(fn ($file) => Str::endsWith($file, ['.sql', '.sql.gz']));