[tests] Make test more robust

Reduce use of magic values
stefna · Feb 15, 2022 · e24667f · e24667f
1 parent a9c7db3
commit e24667f
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/tests/Handler/BugsnagHandlerTest.php b/tests/Handler/BugsnagHandlerTest.php
@@ -10,7 +10,7 @@
 
 class BugsnagHandlerTest extends TestCase
 {
-	/** @var Client|\PHPUnit\Framework\MockObject\MockObject */
+	/** @var Client&\PHPUnit\Framework\MockObject\MockObject */
 	private $client;
 
 	protected function setUp(): void
@@ -54,11 +54,11 @@ public function testEmptyFilterNamespaces(): void
 		$handler = new BugsnagHandler($this->client);
 		$handler->setFilter([]);
 
-		$this->assertCount(11, $report->getStacktrace()->getFrames());
+		$frameCount = count($report->getStacktrace()->getFrames());
 
 		$handler->cleanStacktrace($report);
 
-		$this->assertCount(11, $report->getStacktrace()->getFrames());
+		$this->assertCount($frameCount, $report->getStacktrace()->getFrames());
 	}
 
 	public function testNoneExistingNamespaceFilter(): void
@@ -68,11 +68,11 @@ public function testNoneExistingNamespaceFilter(): void
 		$handler = new BugsnagHandler($this->client);
 		$handler->setFilter(['Sunkan\\']);
 
-		$this->assertCount(11, $report->getStacktrace()->getFrames());
+		$frameCount = count($report->getStacktrace()->getFrames());
 
 		$handler->cleanStacktrace($report);
 
-		$this->assertCount(11, $report->getStacktrace()->getFrames());
+		$this->assertCount($frameCount, $report->getStacktrace()->getFrames());
 	}
 
 	public function testFilterNamespaces(): void
@@ -82,11 +82,11 @@ public function testFilterNamespaces(): void
 		$handler = new BugsnagHandler($this->client);
 		$handler->setFilter(['PHPUnit\\']);
 
-		$this->assertCount(11, $report->getStacktrace()->getFrames());
+		$frameCount = count($report->getStacktrace()->getFrames());
 
 		$handler->cleanStacktrace($report);
 
-		$this->assertCount(2, $report->getStacktrace()->getFrames());
+		$this->assertCount($frameCount - 9, $report->getStacktrace()->getFrames());
 	}
 
 	public function testIncludeContext(): void