[processor] Prevent accidental calls to global functions #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if any of the values is the string 'header' or 'die' then that global function gets called. This should be done explicitly if indended. Issue: MOYA-1244
Marrikulus
force-pushed
the
MOYA-1244/restrict-CallableContextProcessor-from-calling-string-global-functions
branch
from
6014389 to
a97aff2
Compare
|
Can you add a test case |
|
@Marrikulus The Processor takes in a LogRecord, not an array. Did you try to run the tests locally? Also, would it be better to try to add this test to the |
Assert that string functions don't get called only closures Issue: MOYA-1244
Marrikulus
force-pushed
the
MOYA-1244/restrict-CallableContextProcessor-from-calling-string-global-functions
branch
from
4c6cf69 to
2c25750
Compare
sunkan
approved these changes
Dec 20, 2023
bix0r
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if any of the values is the string 'header' or 'die' then that global function gets called.
This should be done explicitly if indended.
Issue: MOYA-1244