fix: optional params may be undefined (4Catalyzer#1057)

steinybot · Jan 31, 2024 · ebde858 · ebde858
1 parent 2ce1eb6
commit ebde858
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/typeUtils.ts b/src/typeUtils.ts
@@ -39,11 +39,11 @@ type Omit<T, K extends keyof any> = Pick<T, Exclude<keyof T, K>>;
 //   RESOLVE_MATCH: '@@found/RESOLVE_MATCH';
 // };
 
-export type Params = Record<string, string>;
+export type Params = Record<string, string | undefined>;
 
 export type ParamsDescriptor = Record<
   string,
-  string | number | boolean | Record<string, unknown>
+  string | number | boolean | Record<string, unknown> | undefined
 >;
 
 // These need to be interfaces to avoid circular reference issues.

diff --git a/test/Matcher.test.ts b/test/Matcher.test.ts
@@ -223,8 +223,7 @@ describe('Matcher', () => {
       const missingMatch = matcher.match({ pathname: '/a' });
 
       if (missingMatch != null && 0 in missingMatch.params) {
-        // FIXME: This type is wrong. It should be string | undefined.
-        const param: string = missingMatch.params[0];
+        const param: string | undefined = missingMatch.params[0];
         expect(param).toBeUndefined();
       }