Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Add lp dapp challenge #543

Merged
merged 22 commits into from
Sep 20, 2023
Merged

Add lp dapp challenge #543

merged 22 commits into from
Sep 20, 2023

Conversation

Julian-dev28
Copy link
Contributor

This PR adds the LP dApp challenge to the Soroban Dapps Challenges

@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr543.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr543.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr543.previews.kube001.services.stellar-ops.com/

2 similar comments
@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr543.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr543.previews.kube001.services.stellar-ops.com/

@Julian-dev28
Copy link
Contributor Author

Julian-dev28 commented Aug 15, 2023 •
edited
Loading

Copy is finished. On Standby for legal review

Asana Ticket

@Julian-dev28 Julian-dev28 marked this pull request as ready for review August 18, 2023 21:45
@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr543.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr543.previews.kube001.services.stellar-ops.com/

2 similar comments
@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr543.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr543.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr543.previews.kube001.services.stellar-ops.com/

ElliotFriend
ElliotFriend reviewed Sep 15, 2023
View reviewed changes
Copy link
Contributor

@ElliotFriend ElliotFriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! I added a couple of questions/comments here and there, but overall, things look really strong!

Personally, I learned a bunch from what you wrote about including the .soroban directory in the necessary place before publishing to vercel. Thanks!!

dapps/dapp-challenges/challenge-2-liquidity-pool.mdx Show resolved Hide resolved
dapps/dapp-challenges/challenge-2-liquidity-pool.mdx Outdated Show resolved Hide resolved
dapps/dapp-challenges/challenge-2-liquidity-pool.mdx Outdated Show resolved Hide resolved
dapps/dapp-challenges/challenge-2-liquidity-pool.mdx Outdated Show resolved Hide resolved
dapps/dapp-challenges/challenge-2-liquidity-pool.mdx Outdated Show resolved Hide resolved
dapps/dapp-challenges/challenge-2-liquidity-pool.mdx Show resolved Hide resolved
dapps/dapp-challenges/challenge-2-liquidity-pool.mdx Outdated Show resolved Hide resolved
dapps/dapp-challenges/challenge-2-liquidity-pool.mdx Outdated Show resolved Hide resolved
dapps/dapp-challenges/challenge-2-liquidity-pool.mdx Outdated Show resolved Hide resolved
dapps/dapp-challenges/challenge-2-liquidity-pool.mdx Outdated Show resolved Hide resolved
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr543.previews.kube001.services.stellar-ops.com/

3 similar comments
@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr543.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr543.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr543.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr543.previews.kube001.services.stellar-ops.com/

@Julian-dev28
Copy link
Contributor Author

Hey team! I've addressed your comments which have all been super helpful!
Thanks for the initial reviews.

ElliotFriend
ElliotFriend reviewed Sep 19, 2023
View reviewed changes
Copy link
Contributor

@ElliotFriend ElliotFriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good! I'm not exactly sure which quickstart hash we need to point to, but if you can double-check it, I'd be ready to approve

dapps/dapp-challenges/challenge-2-liquidity-pool.mdx Outdated Show resolved Hide resolved
@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr543.previews.kube001.services.stellar-ops.com/

@ElliotFriend ElliotFriend added the documentation (create) Create a new piece of documentation (new resource, page, tutorial, etc.) label Sep 20, 2023
@ElliotFriend ElliotFriend self-requested a review September 20, 2023 19:49
ElliotFriend
ElliotFriend approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@ElliotFriend ElliotFriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Well done 👍🏻

briwylde08
briwylde08 approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@briwylde08 briwylde08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, looks great!

@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr543.previews.kube001.services.stellar-ops.com/

@Julian-dev28 Julian-dev28 merged commit e16f778 into main Sep 20, 2023
1 check passed
@Julian-dev28 Julian-dev28 deleted the add-lp-dapp-challenge branch September 20, 2023 20:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@briwylde08 briwylde08 briwylde08 approved these changes

@ElliotFriend ElliotFriend ElliotFriend approved these changes

Assignees
No one assigned
Labels
documentation (create) Create a new piece of documentation (new resource, page, tutorial, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Julian-dev28 @stellar-jenkins @ElliotFriend @briwylde08