This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Corrected calculation of max pages. #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s are disabled when table contains less than 10 rows.
|
Preview is available here: |
|
|
MazurakIhor
changed the title
MazurakIhor
changed the title
Julian-dev28
approved these changes
Oct 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, calculation of maxPage works incorrectly.
Let's assume leaderboard list contains 5 records.
pageNumber is equal to 1
PAGE_SIZE is equal to 10.
maxPage = 5 / 10 = 0.5
Controls are disabled if
pageNumber === maxPage. Since pageNumber == 1 and maxPage == 0.5, 'Next' and 'Prev' buttons aren't disabled as values aren't equal.Implemented fix to round up maxPage to the next integer