-
Notifications
You must be signed in to change notification settings - Fork 81
soroban-docs: Update simulateTransaction Docs With New resourceConfig Parameter #683
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!! Is it true that we don't need manual updates to the copy anymore, @ElliotFriend?? :o \o/ (e.g. here for this page)
Preview is available here: |
@Shaptic That is correct!! Just updating the Currently, the "source" files that I use to generate the complete specfile live in my own dinky repo, but will soon(-ish) live alongside this repo here for convenience. @stellarsaur If it's alright with you, I'd love to add some examples and stuff to go along with this before we merge? |
@stellarsaur Is |
Oof, nice catch @ElliotFriend - it is in fact a |
static/openrpc.json
Outdated
"required": false, | ||
"schema": { | ||
"title": "resourceConfig", | ||
"description": "(optional) Configuration for how resources will be calculated", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to say (optional)
because it will be rendered as such if "required": false
static/openrpc.json
Outdated
"instructionLeeway": { | ||
"title": "instructionLeeway", | ||
"description": "Stringified number - Allow this many extra instructions when budgeting resources", | ||
"type": "string" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ElliotFriend is right: it's unfortunately just a number
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for confirming! 😁
@Shaptic @stellarsaur What would be a "usual" value that I might add as an |
And, did this make it into |
@ElliotFriend this will be released as part of 20.1.0, I think! And the default value is something like 3 million? (@stellarsaur to confirm on both) |
Preview is available here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for helping to get this ready!
This PR adds documentation for the new
simulateTransaction
parameter added in this PR.