This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 81
Update resource limits and make a new reference page for them #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview is available here: |
dmkozh
reviewed
Feb 20, 2024
Some of the comments are more applicable in the discussion doc, than they are for developer documentation. So, let's get rid of those.
Preview is available here: |
dmkozh
reviewed
Feb 21, 2024
Preview is available here: |
dmkozh
approved these changes
Feb 22, 2024
ElliotFriend
added a commit
that referenced
this pull request
Feb 23, 2024
* add a reference page on resource limits and fees * remove resource fee/limit tables from "explainer" page * removing some unnecessary comments and entries Some of the comments are more applicable in the discussion doc, than they are for developer documentation. So, let's get rid of those. * remove unnecessary "current is..." language from resource fees
ElliotFriend
added a commit
that referenced
this pull request
Feb 23, 2024
* add an announcement bar about the docs merge, and supporting styles * updated link to rpc helm chart values (#738) * Add v20.2.0 release to `releases.mdx` (#737) * Update releases.mdx * use latest versions * add changelog * update title * Update resource limits and make a new reference page for them (#736) * add a reference page on resource limits and fees * remove resource fee/limit tables from "explainer" page * removing some unnecessary comments and entries Some of the comments are more applicable in the discussion doc, than they are for developer documentation. So, let's get rid of those. * remove unnecessary "current is..." language from resource fees * use by-name params in pagination example (#743) Refs: #728 --------- Co-authored-by: shawn <[email protected]> Co-authored-by: Julian Martinez <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Phase 0/1 resource fee/limits, and also pulls the technical details of those into a Reference page, and out of the "explainer" page inside Soroban Internals.