Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Update fee page, close #710 #745

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Update fee page, close #710 #745

merged 2 commits into from
Feb 23, 2024

Conversation

janewang
Copy link
Contributor

No description provided.

@stellar-jenkins
Copy link

Copy link
Contributor

@ElliotFriend ElliotFriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic!! You've really improved this article A LOT! I've left a few comments, and almost all of them are tiny nitpicks that I wouldn't insist on.

Thanks!

docs/soroban-internals/fees-and-metering.mdx Outdated Show resolved Hide resolved

The remainder of this chapter focuses on resource fees, as they are specific to Soroban.
- The inclusion fee is the maximum bid the submitter is willing to pay for inclusion of the transaction. The network uses market dynamics to decide which transaction to include in the ledger — transactions that offer a higher fee are included in the ledger before those with lower inclusion fees. Therefore, inclusion fee is used to prioritize transactions. The inclusion fee can be discounted depending on the traffic. If the ledger is not at capacity, only the minimal base inclusion fee is charged (100 stroops or 10^-5 XLM). If the ledger is at capacity, then the lowest inclusion fee bid is charged. In general, the behavior of the inclusion fee and bidding strategies align with the [classic Stellar fees](https://developers.stellar.org/docs/encyclopedia/fees-surge-pricing-fee-strategies).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here (and probably in the next "Resource Fee" section), I would remove the bullet point. Especially since that paragraph is the only one under this heading.

docs/soroban-internals/fees-and-metering.mdx Outdated Show resolved Hide resolved

### Where to find Resource Fee Info for the Transaction

The best way to find the required resource fee for any Soroban transaction is to use the [`simulateTransaction`](contract-interactions/transaction-simulation.mdx) endpoint from the RPC, which enables you to send a preflight transaction that will return resource fees.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The best way to find the required resource fee for any Soroban transaction is to use the [`simulateTransaction`](contract-interactions/transaction-simulation.mdx) endpoint from the RPC, which enables you to send a preflight transaction that will return resource fees.
The best way to find the required resource fee for any Soroban transaction is to use the [`simulateTransaction`](contract-interactions/transaction-simulation.mdx) method from the RPC, which enables you to send an unsigned transaction that will return resource fees.

docs/soroban-internals/fees-and-metering.mdx Outdated Show resolved Hide resolved
docs/soroban-internals/fees-and-metering.mdx Show resolved Hide resolved
docs/soroban-internals/fees-and-metering.mdx Outdated Show resolved Hide resolved
docs/soroban-internals/fees-and-metering.mdx Show resolved Hide resolved
Copy link
Contributor

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

docs/soroban-internals/fees-and-metering.mdx Outdated Show resolved Hide resolved
Co-authored-by: Elliot Voris <[email protected]>
Co-authored-by: Leigh McCulloch <[email protected]>
@stellar-jenkins
Copy link

@janewang janewang merged commit 92d404f into main Feb 23, 2024
2 checks passed
@janewang janewang deleted the fees branch February 23, 2024 23:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants