[ANCHOR-868] Fix broken docker-compose file #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipliu
reviewed
Nov 22, 2024
| ```shell | ||
| docker build --build-arg BASE_IMAGE=gradle:7.6.4-jdk17 -t anchor-platform:local ./ | ||
| docker compose -f service-runner/src/main/resources/docker-compose.yaml up -d |
There was a problem hiding this comment.
Should we provide a way for developers to start the stack against a locally built image?
There was a problem hiding this comment.
I think this is good idea as I was thinking about it.
I will add a local profile.
...-runner/src/main/kotlin/org/stellar/anchor/platform/run_profiles/RunKotlinReferenceServer.kt
Show resolved
Hide resolved
philipliu
approved these changes
Nov 25, 2024
docs/README.md
Outdated
| To build the Anchor Platform image locally, run the following command in the root directory of the project. | ||
| ```shell | ||
| # In the root directory of the project | ||
| docker build -t stellar/anchor-platform . |
There was a problem hiding this comment.
Do we need to add the :local tag here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
reference_config.yamlfile.v2_stableandlatestprofiles to docker_compose.yamlREADME.mdfileContext
docker_compose.yaml fileTesting
./gradlew testDocumentation
N/A
Known limitations
This will break
typescript-wallet-sdk. The PR to fixtypescript-wallet-sdkis stellar/typescript-wallet-sdk#181