horizon: Improve performance of migrations/64_add_payment_flag_histor…

…y_ops.sql (#5056) Remove index_history_operations_on_is_payment because it is not actually used in the payments query.
stellar · Sep 22, 2023 · 5bfe563 · 5bfe563
1 parent 4391e0b
commit 5bfe563
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 5 deletions.
diff --git a/services/horizon/internal/db2/schema/bindata.go b/services/horizon/internal/db2/schema/bindata.go
diff --git a/services/horizon/internal/db2/schema/migrations/64_add_payment_flag_history_ops.sql b/services/horizon/internal/db2/schema/migrations/64_add_payment_flag_history_ops.sql
@@ -1,9 +1,7 @@
 -- +migrate Up
 
 ALTER TABLE history_operations ADD is_payment boolean;
-CREATE INDEX "index_history_operations_on_is_payment" ON history_operations USING btree (is_payment);
 
 -- +migrate Down
 
-DROP INDEX "index_history_operations_on_is_payment";
 ALTER TABLE history_operations DROP COLUMN is_payment;
diff --git a/services/horizon/internal/db2/schema/migrations/65_drop_payment_index.sql b/services/horizon/internal/db2/schema/migrations/65_drop_payment_index.sql
@@ -0,0 +1,7 @@
+-- +migrate Up
+
+-- index_history_operations_on_is_payment was added in migration 64 but it turns out
+-- the index was not necessary, see https://github.com/stellar/go/issues/5059
+DROP INDEX IF EXISTS "index_history_operations_on_is_payment";
+
+-- +migrate Down