Add test for getRequest

utils/apiclient/client.go

@@ -1,32 +1,48 @@
 package apiclient
 
 import (
+	"encoding/json"
 	"fmt"
+	"io/ioutil"
 	"net/http"
 	"net/url"
 
 	"github.com/pkg/errors"
 )
 
-func (c *APIClient) getRequest(endpoint string, queryParams url.Values) error {
+func (c *APIClient) getRequest(endpoint string, queryParams url.Values) (interface{}, error) {
+	client := c.HTTP
+	if client == nil {
+		client = &http.Client{}
+	}
+
 	fullURL := c.url(endpoint, queryParams)
 	req, err := http.NewRequest("GET", fullURL, nil)
 	if err != nil {
-		return errors.Wrap(err, "http GET request creation failed")
+		return nil, errors.Wrap(err, "http GET request creation failed")
 	}
 
-	client := &http.Client{}
 	resp, err := client.Do(req)
 	if err != nil {
-		return errors.Wrap(err, "http GET request failed")
+		return nil, errors.Wrap(err, "http GET request failed")
 	}
 	defer resp.Body.Close()
 
 	if resp.StatusCode != http.StatusOK {
-		return fmt.Errorf("API request failed with status %d", resp.StatusCode)
+		return nil, fmt.Errorf("API request failed with status %d", resp.StatusCode)
+	}
+
+	body, err := ioutil.ReadAll(resp.Body)
+	if err != nil {
+		return nil, fmt.Errorf("failed to read response body: %w", err)
+	}
+
+	var result interface{}
+	if err := json.Unmarshal(body, &result); err != nil {
+		return nil, fmt.Errorf("failed to unmarshal JSON: %w", err)
 	}
 
-	return nil
+	return result, nil
 }
 
 func (c *APIClient) url(endpoint string, qstr url.Values) string {

utils/apiclient/client_test.go

@@ -4,6 +4,7 @@ import (
 	"net/url"
 	"testing"
 
+	"github.com/stellar/go/support/http/httptest"
 	"github.com/stretchr/testify/assert"
 )
 
@@ -20,3 +21,30 @@ func Test_url(t *testing.T) {
 	furl := c.url("federation", qstr)
 	assert.Equal(t, "https://stellar.org/federation?acct=2382376&federation_type=bank_account&swift=BOPBPHMM&type=forward", furl)
 }
+
+func Test_getRequest(t *testing.T) {
+	friendbotFundResponse := `{"key": "value"}`
+
+	hmock := httptest.NewClient()
+	c := &APIClient{
+		BaseURL: "https://stellar.org",
+		HTTP:    hmock,
+	}
+	hmock.On(
+		"GET",
+		"https://stellar.org/federation?acct=2382376&federation_type=bank_account&swift=BOPBPHMM&type=forward",
+	).ReturnString(200, friendbotFundResponse)
+	qstr := url.Values{}
+
+	qstr.Add("type", "forward")
+	qstr.Add("federation_type", "bank_account")
+	qstr.Add("swift", "BOPBPHMM")
+	qstr.Add("acct", "2382376")
+
+	result, err := c.getRequest("federation", qstr)
+	if err != nil {
+		t.Fatal(err)
+	}
+	expected := map[string]interface{}{"key": "value"}
+	assert.Equal(t, expected, result)
+}

utils/apiclient/main.go

@@ -1,6 +1,18 @@
 package apiclient
 
+import (
+	"net/http"
+	"net/url"
+)
+
+type HTTP interface {
+	Do(req *http.Request) (resp *http.Response, err error)
+	Get(url string) (resp *http.Response, err error)
+	PostForm(url string, data url.Values) (resp *http.Response, err error)
+}
+
 type APIClient struct {
 	BaseURL   string
 	AuthToken string
+	HTTP      HTTP
 }