Skip to content

Commit

Permalink
#4538: updated CHANGELOGs
Browse files Browse the repository at this point in the history
  • Loading branch information
sreuland committed Aug 26, 2024
1 parent be4df19 commit e56e346
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
8 changes: 8 additions & 0 deletions ingest/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Changelog

## Pending

### Fixed
* The Captive Core backend now performs 'online' stellar-core `run` for bounded modes of tx-meta retrieval. Refer to [runFrom.go](./ledgerbackend/run_from.go). Enables core to build, validate, and emit trusted ledger hashes in tx-meta stream from lastest of network for a bounded ledger range. The bounded mode will no longer do the 'offline' mode of running core `catchup` for getting tx-meta from just history archives, which does not guarantee verification of the ledger hashes to that of live network. ([#4538](https://github.com/stellar/go/pull/4538)).
* Note - due to the usage of `run` with LCL set to the `from` , there is now potential for longer run time execution durations due to core having to perform online replay from network latest ledger back to `from`. The longer runtime duration will be proportional to the older age of the `from` ledger.



All notable changes to this project will be documented in this file. This project adheres to [Semantic Versioning](http://semver.org/).

### Stellar Core Protocol 21 Configuration Update:
Expand Down
2 changes: 0 additions & 2 deletions ingest/ledgerbackend/run_from.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ type runFromStream struct {
// from - the ledger sequnce to start streaming additional ledgers there after
// fromHash - the hash of from ledger
// runnerMode - stellarCoreRunnerModePassive or stellarCoreRunnerModeActive
//
// core toml settings, such as for offline, it will disable http port of core as it's not needed.
func newRunFromStream(r *stellarCoreRunner, from uint32, fromHash string, runnerMode stellarCoreRunnerMode) (runFromStream, error) {
// Use ephemeral directories on windows because there is
// no way to terminate captive core gracefully on windows.
Expand Down
3 changes: 3 additions & 0 deletions services/horizon/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ file. This project adheres to [Semantic Versioning](http://semver.org/).
### Fixed

- Horizon: not passing trusted hash to captive-core when configured to run catchup "on disk" ([4538](https://github.com/stellar/go/pull/4538))
* The Captive Core backend now performs 'online' stellar-core `run` for bounded modes of tx-meta retrieval, which will be used for `db reingest range` and `ingest verify-range` commands. Enables core to build, validate, and emit trusted ledger hashes in tx-meta stream for the requested ledger range. These bounded range commands will no longer do the 'offline' mode of running core `catchup` for getting tx-meta from just history archives, which does not guarantee verification of the ledger hashes to that of live network. ([#4538](https://github.com/stellar/go/pull/4538)).
* Note - due to the usage of `run` with LCL set to the `from` , there is now potential for longer run time `reingest` and `verify-range` execution durations due to core having to perform online replay from network latest ledger back to `from`. The longer runtime duration will be proportional to the older age of the `from` ledger.


## 2.32.0

Expand Down

0 comments on commit e56e346

Please sign in to comment.