Fix failing unit test

stellar · Nov 21, 2024 · fb94fdf · fb94fdf
1 parent 66abef5
commit fb94fdf
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/ingest/ledger_transaction.go b/ingest/ledger_transaction.go
@@ -62,7 +62,7 @@ func (t *LedgerTransaction) GetChanges() ([]Change, error) {
 			for _, change := range opChanges {
 				op, found := t.GetOperation(uint32(opIdx))
 				if !found {
-					return []Change{}, errors.New("could not find operation")
+					continue
 				}
 				results, _ := t.Result.OperationResults()
 				operationResult := results[opIdx].MustTr()
@@ -115,7 +115,7 @@ func (t *LedgerTransaction) GetChanges() ([]Change, error) {
 			for _, change := range opChanges {
 				op, found := t.GetOperation(uint32(opIdx))
 				if !found {
-					return []Change{}, errors.New("could not find operation")
+					continue
 				}
 				results, _ := t.Result.OperationResults()
 				operationResult := results[opIdx].MustTr()
@@ -194,7 +194,7 @@ func (t *LedgerTransaction) operationChanges(ops []xdr.OperationMeta, index uint
 	for _, change := range changes {
 		op, found := t.GetOperation(index)
 		if !found {
-			return []Change{}, errors.New("could not find operation")
+			continue
 		}
 		results, _ := t.Result.OperationResults()
 		operationResult := results[index].MustTr()

diff --git a/xdr/transaction_envelope.go b/xdr/transaction_envelope.go
@@ -215,6 +215,10 @@ func (e TransactionEnvelope) Preconditions() Preconditions {
 // Note for fee bump transactions, Operations() returns the operations
 // of the inner transaction
 func (e TransactionEnvelope) Operations() []Operation {
+	// This is not expected to happen.
+	if (e == TransactionEnvelope{}) {
+		return []Operation{}
+	}
 	switch e.Type {
 	case EnvelopeTypeEnvelopeTypeTxFeeBump:
 		return e.FeeBump.Tx.InnerTx.V1.Tx.Operations