historyarchive: should not use default logger

[2opremio]

For instance:

go/historyarchive/archive_pool.go

Lines 109 to 114 in a4e5a3f

	// Intentionally avoid logging context errors
	if stats := ai.GetStats(); len(stats) > 0 {
	log.WithField("error", err).Warnf(
	"Encountered an error with archive '%s'",
	stats[0].GetBackendName())
	}

Causes a log to happen without any control. A logger, controlled by the caller, should be used instead or no logging should happen.

For instance, this causes untrackable logs to happen in tests . e.g: https://github.com/stellar/soroban-rpc/actions/runs/9538438244/job/26287637351?pr=216#step:10:22

The log cannot be attributed to a particular test, which is problematic (and noisy)

[urvisavla]

@tamirms , @sreuland, should we also be following to the same pattern of passing the logger object when creating the DataStore object here?