Misc fixes #5352
Merged
Misc fixes #5352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreuland
reviewed
Jun 17, 2024
sreuland
reviewed
Jun 17, 2024
sreuland
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
I left comment for consideration, using interface vs struct for log line writer. your choice, otherwise, lgtm!
|
Unfortunately this didn't fully fix the logging race condition, we should fix #5342 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5351
Closes #5350 (including the removal of a nasty cast)
Addresses part of #5349
Remove redundant code of
(*Session) Begin()