Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

horizon: update core testing image #5049

Merged
merged 11 commits into from
Sep 14, 2023

Conversation

tsachiherman
Copy link
Contributor

@tsachiherman tsachiherman commented Sep 12, 2023

What

The goal of this PR is to update the following:

  • core package
  • core docker image name
  • rpc docker container
  • rs-soroban-sdk

Why

Update before release, to confirm all fixes.

Known limitations

n/a

@tsachiherman tsachiherman added this to the Soroban Testnet Release milestone Sep 12, 2023
@tsachiherman tsachiherman self-assigned this Sep 12, 2023
@tamirms tamirms marked this pull request as ready for review September 14, 2023 17:43
@tamirms tamirms requested a review from a team September 14, 2023 17:44
@tamirms tamirms merged commit af0378b into stellar:master Sep 14, 2023
36 checks passed
PROTOCOL_20_CORE_DEBIAN_PKG_VERSION: 19.13.1-1469.76fed6ead.focal~soroban
PROTOCOL_20_CORE_DOCKER_IMG: stellar/unsafe-stellar-core-next:19.13.1-1469.76fed6ead.focal-soroban
PROTOCOL_20_SOROBAN_RPC_DOCKER_IMG: stellar/soroban-rpc:0.9.4-fix-fees-31
PROTOCOL_20_CORE_DEBIAN_PKG_VERSION: 19.13.1-1481.3acf6dd26.focal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know if this is the latest candidate for release, I recalled seeing mention of ecb24df104c as the one and its on a later package build of 19.13.1-1484.ecb24df10

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the release channel in slack I only see 19.13.1-1481.3acf6dd26.focal
being mentioned:

https://stellarfoundation.slack.com/archives/C04ECVCV162/p1694530045995229

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yesterday had a thread with @sisuresh - https://stellarfoundation.slack.com/archives/C04ECVCV162/p1694648260937719?thread_ts=1694641843.625179&cid=C04ECVCV162, where ecb24df104c was mentioned as the candidate, but maybe that's changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants