Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unnecessary use of fmt.Sprintf #5087

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore: unnecessary use of fmt.Sprintf
Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
  • Loading branch information
testwill committed Oct 23, 2023
commit c1ece428005aa53e81f19c9ce31d1399ff6b576c
2 changes: 1 addition & 1 deletion exp/tools/dump-ledger-state/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"encoding/base64"
"encoding/csv"
"flag"
"fmt"

Check failure on line 8 in exp/tools/dump-ledger-state/main.go

View workflow job for this annotation

GitHub Actions / build (ubuntu-22.04, 1.20)

"fmt" imported and not used

Check failure on line 8 in exp/tools/dump-ledger-state/main.go

View workflow job for this annotation

GitHub Actions / test (ubuntu-22.04, 1.19, 9.6.5)

imported and not used: "fmt"

Check failure on line 8 in exp/tools/dump-ledger-state/main.go

View workflow job for this annotation

GitHub Actions / test (ubuntu-22.04, 1.20, 9.6.5)

"fmt" imported and not used

Check failure on line 8 in exp/tools/dump-ledger-state/main.go

View workflow job for this annotation

GitHub Actions / test (ubuntu-22.04, 1.20, 10)

"fmt" imported and not used

Check failure on line 8 in exp/tools/dump-ledger-state/main.go

View workflow job for this annotation

GitHub Actions / test (ubuntu-22.04, 1.19, 10)

imported and not used: "fmt"
"io"
"os"
"runtime"
Expand Down Expand Up @@ -314,7 +314,7 @@
}

return historyarchive.Connect(
fmt.Sprintf("https://history.stellar.org/prd/core-live/core_live_001/"),
"https://history.stellar.org/prd/core-live/core_live_001/",
historyarchive.ConnectOptions{
UserAgent: "dump-ledger-state",
},
Expand Down
2 changes: 1 addition & 1 deletion exp/tools/dump-orderbook/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"bytes"
"context"
"flag"
"fmt"

Check failure on line 7 in exp/tools/dump-orderbook/main.go

View workflow job for this annotation

GitHub Actions / build (ubuntu-22.04, 1.20)

"fmt" imported and not used

Check failure on line 7 in exp/tools/dump-orderbook/main.go

View workflow job for this annotation

GitHub Actions / test (ubuntu-22.04, 1.19, 9.6.5)

imported and not used: "fmt"

Check failure on line 7 in exp/tools/dump-orderbook/main.go

View workflow job for this annotation

GitHub Actions / test (ubuntu-22.04, 1.20, 9.6.5)

"fmt" imported and not used

Check failure on line 7 in exp/tools/dump-orderbook/main.go

View workflow job for this annotation

GitHub Actions / test (ubuntu-22.04, 1.20, 10)

"fmt" imported and not used

Check failure on line 7 in exp/tools/dump-orderbook/main.go

View workflow job for this annotation

GitHub Actions / test (ubuntu-22.04, 1.19, 10)

imported and not used: "fmt"
"io"
"os"
"strings"
Expand Down Expand Up @@ -116,7 +116,7 @@
}

return historyarchive.Connect(
fmt.Sprintf("https://history.stellar.org/prd/core-live/core_live_001/"),
"https://history.stellar.org/prd/core-live/core_live_001/",
historyarchive.ConnectOptions{
UserAgent: "dump-orderbook",
},
Expand Down
2 changes: 1 addition & 1 deletion tools/archive-reader/archive_reader.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import (
"context"
"flag"
"fmt"

Check failure on line 6 in tools/archive-reader/archive_reader.go

View workflow job for this annotation

GitHub Actions / build (ubuntu-22.04, 1.20)

"fmt" imported and not used

Check failure on line 6 in tools/archive-reader/archive_reader.go

View workflow job for this annotation

GitHub Actions / test (ubuntu-22.04, 1.19, 9.6.5)

imported and not used: "fmt"

Check failure on line 6 in tools/archive-reader/archive_reader.go

View workflow job for this annotation

GitHub Actions / test (ubuntu-22.04, 1.20, 9.6.5)

"fmt" imported and not used

Check failure on line 6 in tools/archive-reader/archive_reader.go

View workflow job for this annotation

GitHub Actions / test (ubuntu-22.04, 1.20, 10)

"fmt" imported and not used

Check failure on line 6 in tools/archive-reader/archive_reader.go

View workflow job for this annotation

GitHub Actions / test (ubuntu-22.04, 1.19, 10)

imported and not used: "fmt"
"io"
"log"

Expand Down Expand Up @@ -63,7 +63,7 @@

func archive() (*historyarchive.Archive, error) {
return historyarchive.Connect(
fmt.Sprintf("s3://history.stellar.org/prd/core-live/core_live_001/"),
"s3://history.stellar.org/prd/core-live/core_live_001/",
historyarchive.ConnectOptions{
S3Region: "eu-west-1",
UnsignedRequests: true,
Expand Down
Loading