Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Use COPY for inserting into accounts table #5115

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

urvisavla
Copy link
Contributor

@urvisavla urvisavla commented Nov 15, 2023

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Optimize the AccountsProcessor to use FastBatchInsertBuilder which uses COPY to bulk insert into the database table accounts. Database update and removal operations remain unchanged.

Why

#5098

Known limitations

N/A

@urvisavla urvisavla marked this pull request as ready for review November 15, 2023 07:57
@urvisavla urvisavla marked this pull request as draft November 16, 2023 07:40
@urvisavla urvisavla force-pushed the 5098/accounts-processor branch from 9574984 to b0660a7 Compare November 16, 2023 07:54
@urvisavla urvisavla marked this pull request as ready for review November 16, 2023 07:55
@urvisavla urvisavla force-pushed the 5098/accounts-processor branch from b0660a7 to 9db48b9 Compare November 17, 2023 21:06
@urvisavla urvisavla merged commit 89f7ea0 into stellar:master Nov 20, 2023
26 checks passed
@urvisavla urvisavla deleted the 5098/accounts-processor branch November 20, 2023 04:21
@hethm999
Copy link

hethm999 commented Dec 6, 2023

good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants