-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exp/services/ledgerexporter: Initial draft #5160
exp/services/ledgerexporter: Initial draft #5160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass review! Looks really solid so far! And even has some test coverage 🤌
Have we given any thought to parallel uploads? I'm not sure if it would necessarily provide a performance benefit and it would have a significant add'l complexity, but I'm curious if the idea has discussed.
By parallel uploads do you mean simultaneously uploading to multiple destinations or concurrently exporting multiple ledger ranges? The former can introduce complexity but the latter can be achieved by running multiple instances of ledger exporter, each handling a distinct range. Currently, the ledgerexporter design doesn't restrict multiple instances from running but the only consideration is the machine capacity to run multiple captive-cores on the same system. |
285b2ae
to
79627fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really really well-designed, great work so far @urvisavla! 👏 I need some more time to digest the interactions between the channels but here's a smattering of misc. comments for now.
Co-authored-by: tamirms <[email protected]>
7aee8a5
to
ec4283b
Compare
Co-authored-by: tamirms <[email protected]>
great job 🎉 ! |
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
see README.md