Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ledgerbackend: Add cloud_storage_ledger backend #5260

Merged
merged 58 commits into from
May 7, 2024

Conversation

chowbao
Copy link
Contributor

@chowbao chowbao commented Mar 24, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

BufferedStorageBackend adds in a new ledgerBackend reader for processing txmeta files from a storage service (the only datastore currently implemented is for GCS)

Why

The new ledgerbackend is created to allow reading txmeta from a cloud storage service where the ledgerexporter is writing txmeta files

Known limitations

  • Adding this new backend in did require pulling out some shared logic with LedgerExporter and moving it to support in order to prevent a circular dependencies error. For instance ledgerexporter imports ledgerbackend but also contains the logic for datastore which is also used in ledgerbackend

@chowbao chowbao marked this pull request as ready for review April 19, 2024 14:58
@chowbao chowbao changed the title Add cloud storage ledger backend ledgerbackend: Add cloud storage ledger backend Apr 19, 2024
@chowbao chowbao changed the title ledgerbackend: Add cloud storage ledger backend ledgerbackend: Add cloud_storage_ledger backend Apr 19, 2024
@chowbao chowbao requested a review from Shaptic April 19, 2024 18:31
ingest/ledgerbackend/cloud_storage_backend.go Outdated Show resolved Hide resolved
ingest/ledgerbackend/cloud_storage_backend.go Outdated Show resolved Hide resolved
ingest/ledgerbackend/cloud_storage_backend.go Outdated Show resolved Hide resolved
ingest/ledgerbackend/cloud_storage_backend.go Outdated Show resolved Hide resolved
support/datastore/gcs_datastore.go Outdated Show resolved Hide resolved
ingest/ledgerbackend/cloud_storage_backend.go Outdated Show resolved Hide resolved
ingest/ledgerbackend/cloud_storage_backend.go Outdated Show resolved Hide resolved
Copy link
Contributor

@tamirms tamirms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@chowbao chowbao merged commit 735600a into master May 7, 2024
31 checks passed
@tamirms tamirms deleted the add_cloud_storage_ledger_backend branch May 7, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants