-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ledgerbackend: Add cloud_storage_ledger backend #5260
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
chowbao
commented
Apr 19, 2024
chowbao
changed the title
Add cloud storage ledger backend
ledgerbackend: Add cloud storage ledger backend
Apr 19, 2024
chowbao
changed the title
ledgerbackend: Add cloud storage ledger backend
ledgerbackend: Add cloud_storage_ledger backend
Apr 19, 2024
Shaptic
reviewed
Apr 19, 2024
sreuland
reviewed
Apr 19, 2024
sreuland
reviewed
Apr 19, 2024
tamirms
reviewed
Apr 19, 2024
sreuland
reviewed
May 6, 2024
tamirms
reviewed
May 6, 2024
tamirms
reviewed
May 6, 2024
tamirms
reviewed
May 6, 2024
tamirms
reviewed
May 6, 2024
tamirms
reviewed
May 6, 2024
tamirms
reviewed
May 6, 2024
tamirms
reviewed
May 6, 2024
tamirms
reviewed
May 6, 2024
Co-authored-by: tamirms <[email protected]>
Co-authored-by: tamirms <[email protected]>
Co-authored-by: tamirms <[email protected]>
tamirms
approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
BufferedStorageBackend adds in a new ledgerBackend reader for processing txmeta files from a storage service (the only datastore currently implemented is for GCS)
Why
The new ledgerbackend is created to allow reading txmeta from a cloud storage service where the ledgerexporter is writing txmeta files
Known limitations