Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

horizon: Clean up integration test variables #5288

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

2opremio
Copy link
Contributor

@2opremio 2opremio commented Apr 21, 2024

All tests use captive-core so there is no need to specify it explicitly.

Soroban-rpc is enabled on a test by test basis so there is no need to guard it through its own env variable.

All tests use captive-core so there is no need to specify it explicitly.

Soroban-rpc is enabled on a test by test based so there is no need to guard it
through its own env variable.
@2opremio 2opremio force-pushed the cleanup-itest-variables branch from 18bc027 to ed96e97 Compare April 21, 2024 18:45
@2opremio 2opremio requested a review from tamirms April 21, 2024 19:35
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleting code 👏 👏 👏

@2opremio 2opremio merged commit 1042b62 into stellar:master Apr 21, 2024
31 checks passed
@2opremio 2opremio deleted the cleanup-itest-variables branch April 21, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants