Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/regulated-assets-approval-server: bump the Go version in Dockerfile that it was missed in #5249 #5294

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

marcelosalloum
Copy link
Contributor

@marcelosalloum marcelosalloum commented Apr 26, 2024

PR Checklist ### PR Structure
  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Bump the Go version in Dockerfile that it was missed in #5249

Why

The toolchain command in go.mod was requiring a Go version newer than the one in the Dockerfile, which was causing docker-build to fail.

Toolchain command:

go/go.mod

Lines 3 to 5 in ee9bbbf

go 1.22
toolchain go1.22.1

Container version incompatible with that toolchain version:

@marcelosalloum marcelosalloum self-assigned this Apr 26, 2024
@marcelosalloum marcelosalloum marked this pull request as ready for review April 26, 2024 16:40
Copy link

@marwen-abid marwen-abid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcelosalloum marcelosalloum force-pushed the marcelo/fix-sep8-deploy branch from 6cbf74a to b3eafb0 Compare April 29, 2024 12:41
@marcelosalloum marcelosalloum merged commit 5f50829 into master Apr 29, 2024
31 checks passed
@marcelosalloum marcelosalloum deleted the marcelo/fix-sep8-deploy branch April 29, 2024 15:37
@marcelosalloum
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants