ledgerexporter: Add lexicographical ordering token to filenames #5305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
For HUBBLE-395
Add a lexicographical ordering token as a prefix to the partition and file names so that the first file within a cloud storage bucket (e.g. GCS) is the largest ledger sequence number.
Example:
/bucket/FFFF05FE--64001-128000/FFFF05FE--64001-64064.xdr.gz
Note that the sort token is
MaxUint32-(start partition ledger or start file ledger)
in hexWhy
The current ordering of partitions and files are integers but the sorting in GCS is alphanumeric making some files appear out of order within GCS.
Known limitations
This does add more text to the filenames which make it slightly less human readable.