Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp/services/ledgerexporter/internal: Fix adjustLedgerRange() #5325

Merged
merged 1 commit into from
May 30, 2024

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented May 29, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

adjustLedgerRange() attempts to clamp the start and end ledger for a given ledger range so that they align on the ledgers per file boundary. However, there is a bug in the implementation because the end ledger should be aligned to the last ledger in the file.

For example, if we attempt to export ledgers in the range of [1, 50] assuming 64 ledgers per file, the adjusted range should be [2, 63] based on this logic:

https://github.com/stellar/go/blob/master/exp/services/ledgerexporter/internal/exportmanager.go#L54-L64

The current code instead adjusts the range to [2, 64] which is incorrect because 64 is the start ledger of the next ledger file

Known limitations

[N/A]

@tamirms tamirms requested a review from a team May 29, 2024 23:42
@tamirms tamirms merged commit e86ca9f into stellar:master May 30, 2024
31 checks passed
@tamirms tamirms deleted the fix-adjust-ledger-range branch May 30, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants