Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp/lighthorizon: delete lighthorizon #5334

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

urvisavla
Copy link
Contributor

@urvisavla urvisavla commented Jun 6, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Delete exp/lighthorizon code.

Why

We merged the lighthorizon branch at the beginning of the CDP (ledger exporter) work, but we didn't end up using it. So it would be best to delete it to avoid maintaining unused code and to prevent others from using it as it is not actively managed. Additionally, it contains the references to ledger exporter related build files which could be confusing.

Known limitations

N/A

@urvisavla urvisavla added the WIP label Jun 6, 2024
@urvisavla urvisavla force-pushed the delete-lighthorizon branch 2 times, most recently from b8933db to e3570c2 Compare June 14, 2024 21:38
@urvisavla urvisavla force-pushed the delete-lighthorizon branch from e3570c2 to c019cf5 Compare June 24, 2024 00:46
@urvisavla urvisavla changed the title (WIP) Delete lighthorizon exp/lighthorizon: delete lighthorizon Jun 24, 2024
@urvisavla urvisavla marked this pull request as ready for review June 24, 2024 00:49
@urvisavla urvisavla removed the WIP label Jun 24, 2024
@urvisavla urvisavla requested review from tamirms and a team June 24, 2024 05:28
@urvisavla urvisavla force-pushed the delete-lighthorizon branch from c019cf5 to 766314c Compare June 24, 2024 05:29
@urvisavla urvisavla force-pushed the delete-lighthorizon branch from 766314c to ccbc145 Compare June 24, 2024 17:18
@urvisavla urvisavla merged commit 132b84c into stellar:master Jun 24, 2024
23 checks passed
@urvisavla urvisavla deleted the delete-lighthorizon branch June 24, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants