services/friendbot: support funding existing accounts #5399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaptic
reviewed
Jul 24, 2024
Shaptic
approved these changes
Jul 25, 2024
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Support funding existing accounts in Friendbot.
If an account does not exist, do as done today, create the account with the starting balance.
If an account exists, and balance is equal to or above the starting balance, error as the account is funded sufficiently.
If an account exists, and balance is below the starting balance, send a payment to the account of the starting balance.
Why
The stellar-cli supports funding accounts and there's a request to support funding to top up existing accounts that have spent funds (stellar/stellar-cli#1389).
There are reasons why this shouldn't be done. It's possible for someone to more easily exhaust the testnet native balance available. However, it is really already very easy to do that by simply passing random addresses. And because this change doesn't allow unlimited funding of a single account without moving funds out of the account the same amount of friction will exist as it does today to someone wishing to accumulate lots of testnet native.
Close stellar/stellar-cli#1389