protocols/horizon: Reinstate errorResultXdr with deprecation warning #5496
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
CHANGELOG.md
within the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
In #5445 ,
errorResultXdr
was renamed toerror_result_xdr
. Although the v22 is a major release, we should provide a pathway for horizon clients to upgrade without incurring any downtime. So, will still include the field in the async txsub response and in the v23 release we can removeerrorResultXdr
entirely.This commit also includes deprecation warnings in the changelog for
num_archived_contracts
andarchived_contracts_amount
from the/assets
response. From protocol 23 onwards it will be difficult to track archived contract balances because archived balances will eventually be evicted and horizon will not be able to determine how many archived balances live outside the bucketlist.