services/horizon: Add missing skip-txmeta flag in the /transactions/ endpoint.

[urvisavla]

PR Checklist

PR Structure

• This PR has reasonably narrow scope (if not, break it down into smaller PRs).
• This PR avoids mixing refactoring changes with feature changes (split into two PRs
  otherwise).
• This PR's title starts with name of package that is most changed in the PR, ex.
  services/friendbot, or all or doc if the changes are broad or impact many
  packages.

Thoroughness

• This PR adds tests for the most critical parts of the new functionality or fixes.
• I've updated any docs (developer docs, .md
  files, etc... affected by this change). Take a look in the docs folder for a given service,
  like this one.

Release planning

• I've reviewed the changes in this PR and if I consider them worthwhile for being mentioned on release notes then I have updated the relevant CHANGELOG.md within the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.
• I've decided if this PR requires a new major/minor version according to
  semver, or if it's mainly a patch change. The PR is targeted at the next
  release branch if it's not a patch change.

What

Add missing skip-txmeta flag in the /transactions/{tx-id} endpoint.

Why

skip-txmeta flag was implemented in #5228. However, the /transactions/ endpoint was missed. As a result, the 22.0.0-rc2 horizon deployed on the testnet still includes result_meta_xdr in its response.

Known limitations

N/A

[mollykarcher]

It was the overall intent of this config to prevent/help data growth, so we wanted to stop saving txmeta xdr to the database when it was enabled.

My question is, if all that's needed to fix this issue is this filtering change at the API layer, that still seems like a bug, because there shouldn't even have been xdr/meta saved in the database for the API to serve. Am I misunderstanding something?

[urvisavla]

It was the overall intent of this config to prevent/help data growth, so we wanted to stop saving txmeta xdr to the database when it was enabled.

My question is, if all that's needed to fix this issue is this filtering change at the API layer, that still seems like a bug, because there shouldn't even have been xdr/meta saved in the database for the API to serve. Am I misunderstanding something?

I’ll need to verify but my guess is that it’s likely the older ledgers where the flag wasn’t enabled. I believe it should be empty for the most recent ledgers but i'll verify.

[mollykarcher]

Ah yeah, you're right. Looking through /transactions?order=desc and it's absent for all recent ones. 👍

[mollykarcher]

Another note, we might consider dropping the data in these columns for all historical stuff, via a manual SQL command.