Include operation information in the ingest.Change struct

[karthikiyer56]

PR Checklist

PR Structure

• This PR has reasonably narrow scope (if not, break it down into smaller PRs).
• This PR avoids mixing refactoring changes with feature changes (split into two PRs
  otherwise).
• This PR's title starts with name of package that is most changed in the PR, ex.
  services/friendbot, or all or doc if the changes are broad or impact many
  packages.

Thoroughness

• This PR adds tests for the most critical parts of the new functionality or fixes.
• [] I've updated any docs (developer docs, .md
  files, etc... affected by this change). Take a look in the docs folder for a given service,
  like this one.

Release planning

• I've reviewed the changes in this PR and if I consider them worthwhile for being mentioned on release notes then I have updated the relevant CHANGELOG.md within the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.
• I've decided if this PR requires a new major/minor version according to
  semver, or if it's mainly a patch change. The PR is targeted at the next
  release branch if it's not a patch change.

What

This PR deals with this github issue - #5535

Why

Details in the associated github issue - github issue - #5535

Tl;DR:

• This serves as as the basis for identifying exactly what operation/activity caused the change in ledgreEntry
• This change serves as a precursor for writing several generic change/transaction processors, primarily offer+trade processor

Known limitations

These extensions to the Change struct do not work when the compacting change reader is used.

[TODO or N/A]

[tamirms]

@karthikiyer56 TestLiquidityPoolDepositDetails in master/services/horizon/internal/ingest/processors/transaction_operation_wrapper_test.go is one of the unit tests that is failing on your branch.

I looked into it and the reason it is failing is because the ingest.LedgerTransaction instance in the test is not complete. It is missing the transaction envelope.

The test exercises a code path where GetOperationChanges() is called on the ingest.LedgerTransaction instance. It fails there because you have modified the code to include operation details into the change. The operation info is pulled from the transaction envelope (which is the right thing to do). However, because the test case does not populate the ingest.LedgerTransaction instance with a transaction envelop, the operation is not found and that causes the test not to pass.

[karthikiyer56]

@karthikiyer56 TestLiquidityPoolDepositDetails in master/services/horizon/internal/ingest/processors/transaction_operation_wrapper_test.go is one of the unit tests that is failing on your branch.

I looked into it and the reason it is failing is because the ingest.LedgerTransaction instance in the test is not complete. It is missing the transaction envelope.

The test exercises a code path where GetOperationChanges() is called on the ingest.LedgerTransaction instance. It fails there because you have modified the code to include operation details into the change. The operation info is pulled from the transaction envelope (which is the right thing to do). However, because the test case does not populate the ingest.LedgerTransaction instance with a transaction envelop, the operation is not found and that causes the test not to pass.

Yup.
Earlier in the day, when the code was fetching operational results, more tests were failing because the ledger operations were missing in more tests.
I tried fixing them, and they still were failing, even when i did add operations to a few test fixtures

So, i decided to simplify the data returned in the change structure 😓
Just as well, since we can derive more details from just envelope and tx result, at the call site itself, when we use the code in trades processing.

At any rate,i thought the latest changes should not cause any unit test failures anymore. I'll look into the one that is failing now.

Good call-out.
Ima just pass a pointer to the ingest.edgerTransaction itself in change,instead of TX envelope and result pair

[tamirms]

looks great! I left a couple suggestions regarding style