Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified trades and offers processor #5545

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

karthikiyer56
Copy link
Contributor

@karthikiyer56 karthikiyer56 commented Dec 7, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've reviewed the changes in this PR and if I consider them worthwhile for being mentioned on release notes then I have updated the relevant CHANGELOG.md within the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

This PR relates to issue #5543

[TODO: Short statement about what is changing.]

Why

[TODO: Why this change is being made. Include any context required to understand the why.]

Known limitations

[TODO or N/A]

GetTradeEventType() TradeEventType // Method to retrieve the type of the trade event
}

type OfferBase struct {
Copy link
Contributor Author

@karthikiyer56 karthikiyer56 Dec 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no mention of sellerId or offerId
just amounts, price and flags.

The reason why I am not using xdr.OfferEntry struct for this is:
It is not a given that an offer will ever create an entry (if it is fully filled)
this distinction helps in the OfferUpdatedEvent where I am capturing prev state and updated state
And also the fact that there is no offerId or sellerId

@karthikiyer56 karthikiyer56 changed the title sample test to test offer updates Unified trades and offers processor Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant