Push config defaults to the default values file in horizon #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacekn
requested changes
Oct 22, 2024
There was a problem hiding this comment.
This change could break people's workloads as they may be using existing names for the values. For this reason I think it would be best to collaborate on a plan for the chart improvements before making this change. Once we have a plan we could communicate it to users to limit disruptions.
|
I removed the |
jacekn
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the config options and defaults up to the default helm values file
Currently there is no documentation of all of the config options in the values file. In addition the configmaps actually take specific values and are not open ended. This PR makes it easier to see what values are actually being used
This also alphabetizes the web config and removes an unused if statement