Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDP-1060] publish multi-tenant helm charts for SDP 2.0.0 #80

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

marwen-abid
Copy link
Contributor

We need to publish the helm charts for the multi-tenant SDP.

🚨 we have to be careful when publishing the new helm charts to avoid undesired upgrades.

@marwen-abid marwen-abid self-assigned this Apr 5, 2024
@marwen-abid marwen-abid requested a review from a team April 5, 2024 04:41
@marwen-abid marwen-abid changed the title SDP-1060 Publish multi-tenant helm charts for SDP 2.0.0-rc [SDP-1060] publish multi-tenant helm charts for SDP 2.0.0-rc Apr 5, 2024
@marwen-abid marwen-abid force-pushed the feat/SDP-1060-sdp-mtn-2.0.0-rc1 branch 2 times, most recently from c243e15 to 60be608 Compare April 5, 2024 19:48
@marwen-abid marwen-abid force-pushed the feat/SDP-1060-sdp-mtn-2.0.0-rc1 branch from 60be608 to ac6437b Compare April 5, 2024 20:36
Copy link
Contributor

@jacekn jacekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit too much to review every line but overall is looks fine.

Copy link
Contributor

@marcelosalloum marcelosalloum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'd wait to merge this once we have the actual 2.0.0 ready, WDYT?

charts/stellar-disbursement-platform/README.md Outdated Show resolved Hide resolved
charts/stellar-disbursement-platform/README.md Outdated Show resolved Hide resolved
@marwen-abid marwen-abid changed the title [SDP-1060] publish multi-tenant helm charts for SDP 2.0.0-rc [SDP-1060] publish multi-tenant helm charts for SDP 2.0.0 Jun 6, 2024
Copy link
Contributor

@marcelosalloum marcelosalloum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@marwen-abid marwen-abid merged commit 331e976 into main Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants