Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDP-1280 Fix duplicate base_url in SDP helm chart #88

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

marwen-abid
Copy link
Contributor

@marwen-abid marwen-abid commented Jul 29, 2024

This issue is encountered by the UNICC - because of a different post render validation used by flux
fluxcd/helm-controller#283

This was the way to reproduce the issue using kustomize.

Prepare kustomize.sh and kustomization.yaml

cat > kustomize.sh <<\EOT
#!/bin/bash
cat - > helm-generated-output.yaml
kustomize build . && rm helm-generated-output.yaml
EOT
chmod +x kustomize.sh

cat > kustomization.yaml <<\EOT
resources:
- helm-generated-output.yaml
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
patches: []
EOT

Run helm template

helm template sdp . --post-renderer ./kustomize.sh -f myvalues.yaml

Error on duplicate BASE_URL

Error: error while running post render on files: error while running command /Users/.../dev/helm-charts/charts/stellar-disbursement-platform/kustomize.sh. error output:
Error: map[string]interface {}(nil): yaml: unmarshal errors:
  line 26: mapping key "BASE_URL" already defined at line 16
: exit status 1

Use --debug flag to render out invalid YAML

@marwen-abid marwen-abid self-assigned this Jul 29, 2024
Copy link
Contributor

@marcelosalloum marcelosalloum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants