Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary parentheses in horizon chart #98

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Remove unnecessary parentheses in horizon chart #98

merged 2 commits into from
Oct 22, 2024

Conversation

travertischio
Copy link
Contributor

These parentheses dont do anything and can be removed to prevent any confusion

@travertischio travertischio requested a review from a team October 22, 2024 16:03
jacekn
jacekn approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@jacekn jacekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ISTR there used to be situations where unset variables caused problems without parenteses. But this doesn't seem to be the case any more

@travertischio travertischio merged commit 0919a5d into stellar:main Oct 22, 2024
@travertischio travertischio deleted the parens-horizon branch October 22, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacekn jacekn jacekn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@travertischio @jacekn